Skip to content

index directive and role emit deprecation warnings for python index-types #6970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Dec 29, 2019

Feature or Bugfix

  • Refactoring

Purpose

  • python specific index-types are marked as deprecated in this commit: 3e9182550a (10years ago!)
  • This emits deprecation warnings to remove them in future.

@tk0miya tk0miya added markup type:proposal a feature suggestion labels Dec 29, 2019
@tk0miya tk0miya added this to the 3.0.0 milestone Dec 29, 2019
@tk0miya tk0miya force-pushed the deprecation_pyindextypes branch 2 times, most recently from 664c4e2 to 347b184 Compare December 29, 2019 09:20
@tk0miya tk0miya requested a review from shimizukawa December 29, 2019 09:36
Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the diff.
My concern is that the official Python documentation uses a lot of module and object.

Python official documentation seems to take time to adapt to new writing style like pair: module; blabla.

@tk0miya
Copy link
Member Author

tk0miya commented Jan 11, 2020

@JulienPalard @cocoatomo We'd like to mark some python-specific index-types deprecated obviously (accurately it has already been marked as deprecated in our document). It does not mean they will be removed right away. It will be removed in Sphinx-5.0 (maybe 2 years later). It seems python-doc contains some index entries (see @shimizukawa 's comment). Do you have any opinions for this idea?

@tk0miya tk0miya force-pushed the deprecation_pyindextypes branch from 347b184 to 8b5997d Compare January 11, 2020 16:44
@JulienPalard
Copy link
Contributor

@tk0miya Thanks for the heads up!

Would a proper fix looks like this python/cpython#18004?

If so, feel free to copy-past my seds to the page documenting this deprecation and how to fix it.

@JulienPalard
Copy link
Contributor

@tk0miya have you looked at #6970 (comment)?

@tk0miya
Copy link
Member Author

tk0miya commented Mar 28, 2020

Sorry for the late response. I found problems on i18n with this deprecation. The python index-types are translated on index pages automatically via language configuration.

For example, .. index: builtin: len is translated to the pair of "組み込み関数" and "len" in Japanese document. On the other hand, .. index:: pair: builtin: len is not translated. So it is displayed as pair of "builtin" and "len" even in Japanese docs.

We need to resolve this before the deprecation. So I withdraw this proposal for a while.

Sorry for bothering you.

@tk0miya tk0miya modified the milestones: 3.0.0, 4.0.0 Mar 28, 2020
@tk0miya tk0miya force-pushed the deprecation_pyindextypes branch from 8b5997d to 8197c86 Compare August 3, 2020 14:41
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1fc4e8c). Click here to learn what that means.
The diff coverage is n/a.

@AA-Turner
Copy link
Member

Resolved by #11412.

@AA-Turner AA-Turner closed this Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
markup type:proposal a feature suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants