-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
DOC: Events overview #7904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Events overview #7904
Conversation
whoahh I see a ton of conflicting files here...perhaps I am making this PR against the wrong branch? |
doc/extdev/index.rst
Outdated
|
||
|
||
Extension How-tos | ||
----------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended? It seems not related to "events overview".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, accident, I'll remove
It seems you added the changes into master branch. So I changed the target branch of this PR to master. |
doc/extdev/appapi.rst
Outdated
13. event.doctree-resolved(app, doctree, docname) | ||
- (for any reference node that fails to resolve) event.missing-reference(env, node, contnode) | ||
|
||
14. call builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The builder controls the whole of the build. It starts to work just after "2. builder-inited" event to before "15. build-finished". I thought "generate output files" is better than this.
oops! let me re-work this PR to be on 3.0 since that seems more appropriate |
OK I just started fresh from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
wohoo, thanks! |
This PR adds a short overview of the events emitted during the build process, to help extension developers understand when events happen in relation to one another, and the overall build process.
I tried to incorporate all of the feedback that @tk0miya gave, though likely this will need some more iteration. What do people think?
note: @tk0miya you mentioned an event "
get-env-updated
" but I couldn't find it documented in https://www.sphinx-doc.org/en/master/extdev/appapi.htmlcloses #7215