Skip to content

Conversation

choldgraf
Copy link
Contributor

This PR adds a short overview of the events emitted during the build process, to help extension developers understand when events happen in relation to one another, and the overall build process.

I tried to incorporate all of the feedback that @tk0miya gave, though likely this will need some more iteration. What do people think?

note: @tk0miya you mentioned an event "get-env-updated" but I couldn't find it documented in https://www.sphinx-doc.org/en/master/extdev/appapi.html

closes #7215

@choldgraf
Copy link
Contributor Author

whoahh I see a ton of conflicting files here...perhaps I am making this PR against the wrong branch?

@tk0miya tk0miya changed the base branch from 3.x to master July 2, 2020 12:58


Extension How-tos
-----------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended? It seems not related to "events overview".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, accident, I'll remove

@tk0miya
Copy link
Member

tk0miya commented Jul 2, 2020

It seems you added the changes into master branch. So I changed the target branch of this PR to master.

13. event.doctree-resolved(app, doctree, docname)
- (for any reference node that fails to resolve) event.missing-reference(env, node, contnode)

14. call builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builder controls the whole of the build. It starts to work just after "2. builder-inited" event to before "15. build-finished". I thought "generate output files" is better than this.

@choldgraf
Copy link
Contributor Author

oops! let me re-work this PR to be on 3.0 since that seems more appropriate

@choldgraf choldgraf changed the base branch from master to 3.x July 2, 2020 20:40
@choldgraf
Copy link
Contributor Author

OK I just started fresh from 3.x and switched the target of this PR to 3.x as well. Also addressed your comment about "Generate output files"

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@tk0miya tk0miya merged commit 0c0da9b into sphinx-doc:3.x Jul 3, 2020
@choldgraf
Copy link
Contributor Author

wohoo, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a summary of build phases and core events
2 participants