[FME-8356] - Events - Errors Metadata #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCardozo-SDK
changed the base branch from
master
to
FME-8393-Events-Baseline
…0, but the JSON has the wrong structure
gthea
reviewed
Aug 13, 2025
Comment on lines
58
to
59
| let event = SplitInternalEventWithMetadata(.sdkError, metadata: EventMetadata(type: .SEGMENTS_SYNC_ERROR, data: [])) | ||
| notifyUpdate(event) |
There was a problem hiding this comment.
All of these could be extracted to a method
func notifyError(type: Type) {
let event = SplitInternalEventWithMetadata(.sdkError, metadata: EventMetadata(type: type, data: [])
notifyUpdate(event)
}So it'll end up looking like
Suggested change
| let event = SplitInternalEventWithMetadata(.sdkError, metadata: EventMetadata(type: .SEGMENTS_SYNC_ERROR, data: [])) | |
| notifyUpdate(event) | |
| notifyError(.SEGMENTS_SYNC_ERROR) |
There was a problem hiding this comment.
I'm not sure about this one because it's just two lines to abstract, and in the future we will probably have to build some metadata with actual useful data that will be different for each error.
Co-authored-by: gthea <[email protected]>
|
SonarQube Quality Gate
|
gthea
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS SDK
What did you accomplish?
Now the SDK reports errors with metadata for Flags and Segments sync problems.
How do we test the changes introduced in this PR?
Extra Notes