Skip to content

Handle readiness logic with large segments #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2024
Merged

Handle readiness logic with large segments #326

merged 3 commits into from
Jul 16, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Jul 16, 2024 •
edited
Loading

JavaScript commons library

What did you accomplish?

  • Update readiness manager to consider largeSegmentsEnabled and waitForLargeSegments config options to handle SDK_READY events.

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review July 16, 2024 16:33
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner July 16, 2024 16:33
Base automatically changed from SDKS-8407_new_endpoint to SDKS-8407_baseline July 16, 2024 16:33
javrudsky
javrudsky approved these changes Jul 16, 2024
View reviewed changes
Copy link

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilianoSanchez EmilianoSanchez merged commit 82e4e9c into SDKS-8407_baseline Jul 16, 2024
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-8407_readiness branch July 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javrudsky javrudsky javrudsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @javrudsky