Refactor TypeScript declarations #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JS-Commons and merge
EmilianoSanchez
changed the title
…ns_internal_reuse
…ns_internal_reuse
…ns_internal_reuse
Base automatically changed from
remove_pluggable_localhost_mode
to
breaking_changes_baseline
October 31, 2024 01:47
…ns_internal_reuse
…al_reuse Refactor TypeScript declarations: apply TSDoc linter rules and reuse types internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
Add
SplitIOnamespace, with public TypeScript declarations, to be reused across SDK packages rather than duplicating the namespace on each package.How do we test the changes introduced in this PR?
TS tests in the SDK packages.
Extra Notes