Skip to content

Remove warnings #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Remove warnings #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c89cda8
Fix usage with Zeus
mcmire Feb 14, 2021
f2f2903
Don't 'appraisal install' before running test suite locally
mcmire Feb 14, 2021
b2e82a1
Remove warnings
mcmire Feb 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,31 @@ appraisals = {
rspec_lt_3_10: proc { |with_rails|
version = "< 3.10"

gem "rspec", version

if with_rails
gem "rspec-core", version
gem "rspec-expectations", version
gem "rspec-mocks", version
gem "rspec-support", version
# gem "rspec-core", version
# gem "rspec-expectations", version
# gem "rspec-mocks", version
# gem "rspec-support", version
gem "rspec-rails"
else
gem "rspec", version
# else
# gem "rspec", version
end
},
rspec_gte_3_10: proc { |with_rails|
version = [">= 3.10", "< 4"]

gem "rspec", *version

if with_rails
gem "rspec-core", *version
gem "rspec-expectations", *version
gem "rspec-mocks", *version
gem "rspec-support", *version
# gem "rspec-core", *version
# gem "rspec-expectations", *version
# gem "rspec-mocks", *version
# gem "rspec-support", *version
gem "rspec-rails"
else
gem "rspec", *version
# else
# gem "rspec", *version
end
},
}
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"

gemspec
14 changes: 10 additions & 4 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,27 @@ require_relative "support/current_bundle"

begin
require "rspec/core/rake_task"
RSpec::Core::RakeTask.new(:spec)
RSpec::Core::RakeTask.new(spec: :before_spec) do |config|
config.verbose = true
end
rescue LoadError
task :spec do
appraisal = SuperDiff::CurrentBundle.instance.latest_appraisal
exec "appraisal install && appraisal #{appraisal.name} rake spec --trace"
exec "appraisal #{appraisal.name} rake spec --trace"
end
end

task :default do
if SuperDiff::CurrentBundle.instance.appraisal_in_use?
sh "rake spec"
elsif ENV["CI"]
exec "appraisal install && appraisal rake --trace"
exec "appraisal rake --trace"
else
appraisal = SuperDiff::CurrentBundle.instance.latest_appraisal
exec "appraisal install && appraisal #{appraisal.name} rake --trace"
exec "appraisal #{appraisal.name} rake --trace"
end
end

task :before_spec do
FileUtils.rm_rf(File.expand_path("./spec/tmp", __dir__))
end
1 change: 1 addition & 0 deletions bin/ci/install
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/sh

echo $PWD
bundle config set path $PWD/vendor/bundle
bundle install --jobs=3 --retry=3
1 change: 1 addition & 0 deletions gemfiles/no_rails_rspec_gte_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "rspec", ">= 3.10", "< 4"

gemspec path: "../"
2 changes: 2 additions & 0 deletions gemfiles/no_rails_rspec_gte_3_10.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ GEM
thor (1.0.1)
trollop (1.16.2)
unicode-display_width (1.7.0)
warnings_logger (0.1.1)

PLATFORMS
ruby
Expand All @@ -76,6 +77,7 @@ DEPENDENCIES
rspec (>= 3.10, < 4)
rubocop
super_diff!
warnings_logger

BUNDLED WITH
2.1.4
1 change: 1 addition & 0 deletions gemfiles/no_rails_rspec_lt_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "rspec", "< 3.10"

gemspec path: "../"
2 changes: 2 additions & 0 deletions gemfiles/no_rails_rspec_lt_3_10.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ GEM
thor (1.0.1)
trollop (1.16.2)
unicode-display_width (1.7.0)
warnings_logger (0.1.1)

PLATFORMS
ruby
Expand All @@ -76,6 +77,7 @@ DEPENDENCIES
rspec (< 3.10)
rubocop
super_diff!
warnings_logger

BUNDLED WITH
2.1.4
6 changes: 2 additions & 4 deletions gemfiles/rails_5_0_rspec_gte_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
gem "jdbc-sqlite3", platform: :jruby
gem "activerecord", "~> 5.0.0"
gem "railties", "~> 5.0.0"
gem "sqlite3", "~> 1.3.6", platform: [:ruby, :mswin, :mingw]
gem "rspec-core", ">= 3.10", "< 4"
gem "rspec-expectations", ">= 3.10", "< 4"
gem "rspec-mocks", ">= 3.10", "< 4"
gem "rspec-support", ">= 3.10", "< 4"
gem "rspec", ">= 3.10", "< 4"
gem "rspec-rails"

gemspec path: "../"
11 changes: 7 additions & 4 deletions gemfiles/rails_5_0_rspec_gte_3_10.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ GEM
rake (13.0.1)
regexp_parser (1.7.1)
rexml (3.2.4)
rspec (3.10.0)
rspec-core (~> 3.10.0)
rspec-expectations (~> 3.10.0)
rspec-mocks (~> 3.10.0)
rspec-core (3.10.0)
rspec-support (~> 3.10.0)
rspec-expectations (3.10.0)
Expand Down Expand Up @@ -123,6 +127,7 @@ GEM
tzinfo (1.2.7)
thread_safe (~> 0.1)
unicode-display_width (1.7.0)
warnings_logger (0.1.1)

PLATFORMS
ruby
Expand All @@ -137,14 +142,12 @@ DEPENDENCIES
pry-nav
railties (~> 5.0.0)
rake
rspec-core (>= 3.10, < 4)
rspec-expectations (>= 3.10, < 4)
rspec-mocks (>= 3.10, < 4)
rspec (>= 3.10, < 4)
rspec-rails
rspec-support (>= 3.10, < 4)
rubocop
sqlite3 (~> 1.3.6)
super_diff!
warnings_logger

BUNDLED WITH
2.1.4
6 changes: 2 additions & 4 deletions gemfiles/rails_5_0_rspec_lt_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
gem "jdbc-sqlite3", platform: :jruby
gem "activerecord", "~> 5.0.0"
gem "railties", "~> 5.0.0"
gem "sqlite3", "~> 1.3.6", platform: [:ruby, :mswin, :mingw]
gem "rspec-core", "< 3.10"
gem "rspec-expectations", "< 3.10"
gem "rspec-mocks", "< 3.10"
gem "rspec-support", "< 3.10"
gem "rspec", "< 3.10"
gem "rspec-rails"

gemspec path: "../"
11 changes: 7 additions & 4 deletions gemfiles/rails_5_0_rspec_lt_3_10.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ GEM
rake (13.0.1)
regexp_parser (1.7.1)
rexml (3.2.4)
rspec (3.9.0)
rspec-core (~> 3.9.0)
rspec-expectations (~> 3.9.0)
rspec-mocks (~> 3.9.0)
rspec-core (3.9.2)
rspec-support (~> 3.9.3)
rspec-expectations (3.9.2)
Expand Down Expand Up @@ -123,6 +127,7 @@ GEM
tzinfo (1.2.7)
thread_safe (~> 0.1)
unicode-display_width (1.7.0)
warnings_logger (0.1.1)

PLATFORMS
ruby
Expand All @@ -137,14 +142,12 @@ DEPENDENCIES
pry-nav
railties (~> 5.0.0)
rake
rspec-core (< 3.10)
rspec-expectations (< 3.10)
rspec-mocks (< 3.10)
rspec (< 3.10)
rspec-rails
rspec-support (< 3.10)
rubocop
sqlite3 (~> 1.3.6)
super_diff!
warnings_logger

BUNDLED WITH
2.1.4
6 changes: 2 additions & 4 deletions gemfiles/rails_5_1_rspec_gte_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
gem "jdbc-sqlite3", platform: :jruby
gem "activerecord", "~> 5.1.0"
gem "railties", "~> 5.1.0"
gem "sqlite3", "~> 1.3.6", platform: [:ruby, :mswin, :mingw]
gem "rspec-core", ">= 3.10", "< 4"
gem "rspec-expectations", ">= 3.10", "< 4"
gem "rspec-mocks", ">= 3.10", "< 4"
gem "rspec-support", ">= 3.10", "< 4"
gem "rspec", ">= 3.10", "< 4"
gem "rspec-rails"

gemspec path: "../"
11 changes: 7 additions & 4 deletions gemfiles/rails_5_1_rspec_gte_3_10.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ GEM
rake (13.0.1)
regexp_parser (1.7.1)
rexml (3.2.4)
rspec (3.10.0)
rspec-core (~> 3.10.0)
rspec-expectations (~> 3.10.0)
rspec-mocks (~> 3.10.0)
rspec-core (3.10.0)
rspec-support (~> 3.10.0)
rspec-expectations (3.10.0)
Expand Down Expand Up @@ -123,6 +127,7 @@ GEM
tzinfo (1.2.7)
thread_safe (~> 0.1)
unicode-display_width (1.7.0)
warnings_logger (0.1.1)

PLATFORMS
ruby
Expand All @@ -137,14 +142,12 @@ DEPENDENCIES
pry-nav
railties (~> 5.1.0)
rake
rspec-core (>= 3.10, < 4)
rspec-expectations (>= 3.10, < 4)
rspec-mocks (>= 3.10, < 4)
rspec (>= 3.10, < 4)
rspec-rails
rspec-support (>= 3.10, < 4)
rubocop
sqlite3 (~> 1.3.6)
super_diff!
warnings_logger

BUNDLED WITH
2.1.4
6 changes: 2 additions & 4 deletions gemfiles/rails_5_1_rspec_lt_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
gem "jdbc-sqlite3", platform: :jruby
gem "activerecord", "~> 5.1.0"
gem "railties", "~> 5.1.0"
gem "sqlite3", "~> 1.3.6", platform: [:ruby, :mswin, :mingw]
gem "rspec-core", "< 3.10"
gem "rspec-expectations", "< 3.10"
gem "rspec-mocks", "< 3.10"
gem "rspec-support", "< 3.10"
gem "rspec", "< 3.10"
gem "rspec-rails"

gemspec path: "../"
11 changes: 7 additions & 4 deletions gemfiles/rails_5_1_rspec_lt_3_10.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ GEM
rake (13.0.1)
regexp_parser (1.7.1)
rexml (3.2.4)
rspec (3.9.0)
rspec-core (~> 3.9.0)
rspec-expectations (~> 3.9.0)
rspec-mocks (~> 3.9.0)
rspec-core (3.9.2)
rspec-support (~> 3.9.3)
rspec-expectations (3.9.2)
Expand Down Expand Up @@ -123,6 +127,7 @@ GEM
tzinfo (1.2.7)
thread_safe (~> 0.1)
unicode-display_width (1.7.0)
warnings_logger (0.1.1)

PLATFORMS
ruby
Expand All @@ -137,14 +142,12 @@ DEPENDENCIES
pry-nav
railties (~> 5.1.0)
rake
rspec-core (< 3.10)
rspec-expectations (< 3.10)
rspec-mocks (< 3.10)
rspec (< 3.10)
rspec-rails
rspec-support (< 3.10)
rubocop
sqlite3 (~> 1.3.6)
super_diff!
warnings_logger

BUNDLED WITH
2.1.4
6 changes: 2 additions & 4 deletions gemfiles/rails_5_2_rspec_gte_3_10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@ gem "pry-byebug", platform: :mri
gem "pry-nav", platform: :jruby
gem "rake"
gem "rubocop"
gem "warnings_logger"
gem "activerecord-jdbcsqlite3-adapter", platform: :jruby
gem "jdbc-sqlite3", platform: :jruby
gem "activerecord", "~> 5.2.0"
gem "railties", "~> 5.2.0"
gem "sqlite3", "~> 1.3.6", platform: [:ruby, :mswin, :mingw]
gem "rspec-core", ">= 3.10", "< 4"
gem "rspec-expectations", ">= 3.10", "< 4"
gem "rspec-mocks", ">= 3.10", "< 4"
gem "rspec-support", ">= 3.10", "< 4"
gem "rspec", ">= 3.10", "< 4"
gem "rspec-rails"

gemspec path: "../"
Loading