Add namespace to TestRecord enum & fixed (fix compile in circleci?) #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes these are generated without a namespace Then, we fail to compile because of this Scala bug: scala/bug#4071 We can make sure it gets generated with a namespace by specifying namespace this is valid avro per https://avro.apache.org/docs/current/spec.html#Enums
|
merging this myself because I meant to put these on the same branch & couldn't figure out how to get git working appropriately without this PR :( |
anne-decusatis
added a commit
that referenced
this pull request
Aug 23, 2019
* First pass at CircleCI config.yml based on bits of Scio's config.yml * Remove the invalid(?) yaml & and * * Define jobs outside of build workflow * Fix line breaks in sbt command definition * Remove Travis build * Add namespace to TestRecord enum & fixed (#166) Sometimes these are generated without a namespace Then, we fail to compile because of this Scala bug: scala/bug#4071 We can make sure it gets generated with a namespace by specifying namespace this is valid avro per https://avro.apache.org/docs/current/spec.html#Enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes these are generated without a namespace
Then, we fail to compile because of this Scala bug: scala/bug#4071
We can make sure it gets generated with a namespace by specifying namespace
this is valid avro per https://avro.apache.org/docs/current/spec.html#Enums