Skip to content

Conversation

jto
Copy link
Contributor

@jto jto commented Oct 16, 2018

Fixes #1436

@jto jto requested a review from regadas October 16, 2018 09:17
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #1460 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
+ Coverage   78.98%   78.98%   +<.01%     
==========================================
  Files         170      170              
  Lines        5153     5154       +1     
  Branches      385      310      -75     
==========================================
+ Hits         4070     4071       +1     
  Misses       1083     1083
Impacted Files Coverage Δ
.../src/main/scala/com/spotify/scio/ScioContext.scala 87.28% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7215a95...0b66ad4. Read the comment docs.

output: String,
camelCaseTest: String) // This param will not be parsed properly.

it should "#1436: support came case" in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 camel don't worry I'll fix the typo 😄

@regadas regadas merged commit 8547a8a into master Oct 16, 2018
@regadas regadas deleted the julient/fix-1436-camelCase-typed-arguments branch October 16, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants