-
Notifications
You must be signed in to change notification settings - Fork 527
#1477: Get rid of Future.failed in IOs #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
038b398
to
f4da6ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jto just some rewording comments, otherwise 👍
// scalastyle:on structural.type | ||
} | ||
|
||
final class TapOfNothing[A] private extends TapT[A] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jto should we name this EmptyTapOf[A]
|
||
import scala.concurrent.Future | ||
|
||
sealed trait TapT[A] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jto I think we could move this to Tap.scala
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The only use of the class is to encode the fact the write and tap can either return a Tap[A]
or a Tap[Nothing]
. It's actually not strictly related to Tap
but I can't find a better name...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah on a second thought I agree with you! 👍
|
||
} | ||
|
||
final case object EmptyTap extends Tap[Nothing] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jto 🎨 i think final
here is redundant, since it's a top level object
f4da6ec
to
7f0583e
Compare
7f0583e
to
a0a9932
Compare
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
- Coverage 78.99% 75.96% -3.03%
==========================================
Files 170 170
Lines 5184 5422 +238
Branches 289 420 +131
==========================================
+ Hits 4095 4119 +24
- Misses 1089 1303 +214
Continue to review full report at Codecov.
|
Fixes #1477