Skip to content

Conversation

jto
Copy link
Contributor

@jto jto commented Oct 23, 2018

Fixes #1477

@jto jto requested a review from regadas October 23, 2018 13:53
@jto jto force-pushed the julient/1477-better-IO-types branch from 038b398 to f4da6ec Compare October 24, 2018 12:42
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jto just some rewording comments, otherwise 👍

// scalastyle:on structural.type
}

final class TapOfNothing[A] private extends TapT[A] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jto should we name this EmptyTapOf[A]


import scala.concurrent.Future

sealed trait TapT[A] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jto I think we could move this to Tap.scala?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The only use of the class is to encode the fact the write and tap can either return a Tap[A] or a Tap[Nothing]. It's actually not strictly related to Tap but I can't find a better name...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah on a second thought I agree with you! 👍


}

final case object EmptyTap extends Tap[Nothing] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jto 🎨 i think final here is redundant, since it's a top level object

@jto jto force-pushed the julient/1477-better-IO-types branch from f4da6ec to 7f0583e Compare October 25, 2018 14:05
@jto jto force-pushed the julient/1477-better-IO-types branch from 7f0583e to a0a9932 Compare October 25, 2018 14:31
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #1482 into master will decrease coverage by 3.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
- Coverage   78.99%   75.96%   -3.03%     
==========================================
  Files         170      170              
  Lines        5184     5422     +238     
  Branches      289      420     +131     
==========================================
+ Hits         4095     4119      +24     
- Misses       1089     1303     +214
Impacted Files Coverage Δ
...scala/com/spotify/scio/elasticsearch/package.scala 0% <ø> (ø) ⬆️
...in/scala/com/spotify/scio/values/SCollection.scala 91.45% <ø> (ø) ⬆️
...src/main/scala/com/spotify/scio/jdbc/package.scala 100% <ø> (ø) ⬆️
...in/scala/com/spotify/scio/testing/ScioIOSpec.scala 94.52% <ø> (ø) ⬆️
...ain/scala/com/spotify/scio/cassandra/package.scala 0% <ø> (ø) ⬆️
...ain/scala/com/spotify/scio/cassandra/package.scala 0% <ø> (ø) ⬆️
...scala/com/spotify/scio/elasticsearch/package.scala 0% <ø> (ø) ⬆️
...m/spotify/scio/elasticsearch/ElasticsearchIO.scala 0% <0%> (ø) ⬆️
...-core/src/main/scala/com/spotify/scio/io/Tap.scala 90.9% <0%> (-9.1%) ⬇️
...scala/com/spotify/scio/cassandra/CassandraIO.scala 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b2c85...a0a9932. Read the comment docs.

@regadas regadas merged commit d5603c3 into master Oct 25, 2018
@regadas regadas deleted the julient/1477-better-IO-types branch October 25, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants