-
Notifications
You must be signed in to change notification settings - Fork 523
Feature/sub exists #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sub exists #1483
Conversation
@@ -19,7 +19,7 @@ package com.spotify.scio.pubsub | |||
|
|||
import com.google.pubsub.v1.PublisherGrpc.PublisherBlockingStub | |||
import com.google.pubsub.v1.SubscriberGrpc.SubscriberBlockingStub | |||
import com.google.pubsub.v1.{GetTopicRequest, PublisherGrpc, SubscriberGrpc, Subscription, Topic} | |||
import com.google.pubsub.v1._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenFradet can you keep the expanded version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! @BenFradet
Codecov Report
@@ Coverage Diff @@
## master #1483 +/- ##
===========================================
- Coverage 78.92% 68.44% -10.49%
===========================================
Files 170 170
Lines 5153 5156 +3
Branches 317 396 +79
===========================================
- Hits 4067 3529 -538
- Misses 1086 1627 +541
Continue to review full report at Codecov.
|
This is the sister PR to #1216.
I also removed the
pubsubOptions
param fromnewChannel
since it doesn't seem to be used.I'm keen on writing unit tests for
PubSubAdmin
next if possible.