Skip to content

Conversation

anish749
Copy link
Contributor

@anish749 anish749 commented Nov 1, 2018

The transform name was hard coded to UnionAll for the union all transform, and doesn't pick up the call site name as the transform name. Adding unique names / user defined custom names, helps in easy tracking in the DataFlow UI.

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #1499 into master will decrease coverage by 10.7%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1499       +/-   ##
===========================================
- Coverage   79.16%   68.45%   -10.71%     
===========================================
  Files         173      173               
  Lines        5250     5250               
  Branches      312      315        +3     
===========================================
- Hits         4156     3594      -562     
- Misses       1094     1656      +562
Impacted Files Coverage Δ
.../src/main/scala/com/spotify/scio/ScioContext.scala 85.83% <100%> (-1.57%) ⬇️
...in/scala/com/spotify/scio/values/SCollection.scala 91.41% <100%> (-0.09%) ⬇️
.../scala/com/spotify/scio/bigquery/client/Jobs.scala 0% <0%> (-100%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-100%) ⬇️
...cala/com/spotify/scio/spanner/client/Spanner.scala 0% <0%> (-100%) ⬇️
...ala/com/spotify/scio/bigquery/client/LoadOps.scala 0% <0%> (-100%) ⬇️
.../com/spotify/scio/bigquery/client/ExtractOps.scala 0% <0%> (-100%) ⬇️
...scala/com/spotify/scio/bigquery/MockBigQuery.scala 0% <0%> (-94.74%) ⬇️
...la/com/spotify/scio/bigquery/dynamic/package.scala 0% <0%> (-94.12%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-94.12%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5065d01...41ea49d. Read the comment docs.

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! 👍

@regadas regadas merged commit 3b1787f into spotify:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants