Skip to content

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Nov 20, 2018

No description provided.

@regadas regadas requested a review from jto November 20, 2018 21:03
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #1548 into master will decrease coverage by 0.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage    69.2%   68.32%   -0.89%     
==========================================
  Files         171      171              
  Lines        5241     5240       -1     
  Branches      293      414     +121     
==========================================
- Hits         3627     3580      -47     
- Misses       1614     1660      +46
Impacted Files Coverage Δ
...ain/scala/com/spotify/scio/values/SideOutput.scala 87.5% <100%> (-1.39%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-58.83%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-50%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-46.16%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 37.5% <0%> (-25%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 36.17% <0%> (-4.26%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 25% <0%> (-3.85%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 27.02% <0%> (-2.71%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.79% <0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f727e65...0ba15e2. Read the comment docs.

@jto jto merged commit bb46595 into spotify:master Nov 21, 2018
@regadas regadas deleted the fix/coders branch November 21, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants