Skip to content

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Feb 19, 2019

this is related to #1152. A lot as changed since then:

  • we can now detect the serialization of null values
  • and beam is now 2.10.

Given this and the fact we are still not able to replicate I think we should restore the usage of ListSideInput.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1691 into master will decrease coverage by 0.86%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   69.75%   68.89%   -0.87%     
==========================================
  Files         175      175              
  Lines        5330     5330              
  Branches      300      300              
==========================================
- Hits         3718     3672      -46     
- Misses       1612     1658      +46
Impacted Files Coverage Δ
...in/scala/com/spotify/scio/values/SCollection.scala 91.3% <100%> (ø) ⬆️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-55.56%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-50%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-46.16%) ⬇️
...spotify/scio/coders/instances/AlgebirdCoders.scala 75% <0%> (-25%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 37.5% <0%> (-25%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 24.29% <0%> (-3.74%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 27.02% <0%> (-2.71%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 76.59% <0%> (-2.13%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.79% <0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623d4c9...d6c1bbe. Read the comment docs.

@jto jto merged commit 17f0247 into spotify:master Feb 20, 2019
@regadas regadas deleted the fix/list-si branch November 19, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants