Skip to content

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Mar 11, 2019

Fixes: #1733

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #1743 into master will increase coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1743      +/-   ##
==========================================
+ Coverage   68.46%   69.04%   +0.57%     
==========================================
  Files         175      175              
  Lines        5603     5362     -241     
  Branches      313      397      +84     
==========================================
- Hits         3836     3702     -134     
+ Misses       1767     1660     -107
Impacted Files Coverage Δ
...com/spotify/scio/testing/SCollectionMatchers.scala 96.7% <100%> (+0.03%) ⬆️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-70.59%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-66.67%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-58.98%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50% <0%> (-50%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.82% <0%> (-47.11%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 37.5% <0%> (-25%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0% <0%> (-22.37%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 27.02% <0%> (-10.82%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 24.29% <0%> (-3.74%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d3684...f81c793. Read the comment docs.

@jto jto merged commit b1fd354 into spotify:master Mar 12, 2019
regadas added a commit that referenced this pull request Mar 13, 2019
@regadas regadas deleted the fix/1733 branch November 19, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants