Skip to content

Fix "Service Registry Actuator Endpoint URL" in doc is wrong(#1240) #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix "Service Registry Actuator Endpoint URL" in doc is wrong(#1240) #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/spring-cloud-commons/common-abstractions.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ NOTE: These events will not be fired if the `spring.cloud.service-registry.auto-
[[service-registry-actuator-endpoint]]
=== Service Registry Actuator Endpoint

Spring Cloud Commons provides a `/service-registry` actuator endpoint.
Spring Cloud Commons provides a `/serviceregistry` actuator endpoint.
This endpoint relies on a `Registration` bean in the Spring Application Context.
Calling `/service-registry` with GET returns the status of the `Registration`.
Calling `/serviceregistry` with GET returns the status of the `Registration`.
Using POST to the same endpoint with a JSON body changes the status of the current `Registration` to the new value.
The JSON body has to include the `status` field with the preferred value.
Please see the documentation of the `ServiceRegistry` implementation you use for the allowed values when updating the status and the values returned for the status.
Expand Down
4 changes: 2 additions & 2 deletions ...ork/cloud/client/serviceregistry/endpoint/ServiceRegistryEndpointNoRegistrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ public class ServiceRegistryEndpointNoRegistrationTests {

@Test
public void testGet() throws Exception {
this.mvc.perform(get("/service-registry/instance-status")).andExpect(status().isNotFound());
this.mvc.perform(get("/serviceregistry/instance-status")).andExpect(status().isNotFound());
}

@Test
public void testPost() throws Exception {
this.mvc.perform(post("/service-registry/instance-status").content("newstatus"))
this.mvc.perform(post("/serviceregistry/instance-status").content("newstatus"))
.andExpect(status().isNotFound());
}

Expand Down