Skip to content

chore: Add around tool calling execution #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Apr 23, 2025

Add an extension point for tool calling

@ThomasVitale
Copy link
Contributor

@He-Pin thanks for your contribution. Could you share some more details about your use case for such a change? Thanks!

@markpollack
Copy link
Member

is this to implement a client side parallel tool execution feature?

@He-Pin
Copy link
Contributor Author

He-Pin commented Apr 29, 2025

We need the enhance the function input and result, and which can be rescheduled to a virtual thread pool tool. Otherwise, I have to using an AOP

@ThomasVitale
Copy link
Contributor

I'd like to share the same input as the other task: #2853 (comment)

In addition to that, I should add that DefaultToolCallingManager should have been final, but it kind of slipped away. It's not designed to be extended, but only as a reference default implementation. So I wouldn't introduce abstract methods. The idea is to provide a custom implementation of the ToolCallingManager for customisations and extensions (possibly couple with the delegate pattern).

What do you think?

@He-Pin
Copy link
Contributor Author

He-Pin commented Apr 29, 2025

I need two things

  1. Enhance the input and output of the call, an aop
  2. Passing our ctx data without interfering the current toolcontext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants