Feat messages builder #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved readability using String.format
update branch update
The complex constructor in AbstractMessage has been simplified and the AbstractMessageBuilder class has been added for flexible extension.
apply Builder Pattern
apply Builder pattern
apply Builder Pattern
apply Builder pattern
apply Builder Pattern
Modify files that have a dependency relationship with Message.
Modify files that have a dependency relationship with Message
Modify files that have a dependency relationship with Message
Reflecting changes to the Message Interface
|
With 3 arguments, not sure how much value there is to having the builder. Also, the design pattern to follow that is consistent with the spring ecosystem is to have the Builder class be internal to the product class itself. I'm going to create an issue, in a way related to the similar options PR you made to discuss how to approach. |
|
Closing the PR as we got to it late and needs more design discussion. opened #1594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complex constructor in AbstractMessage has been simplified and the AbstractMessageBuilder class has been added for flexible extension.
#408