Use nimbus-jose-jwt and oauth2-oidc-sdk versions from spring-security #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
requested changes
Mar 15, 2021
oauth2-authorization-server/spring-security-oauth2-authorization-server.gradle
Outdated
Show resolved
Hide resolved
jgrandja
added
type: dependency-upgrade
Kehrlann
force-pushed
the
align-nimbus-with-spring-security
branch
from
6acfdd8 to
5d93772
Compare
|
Also bumped Boot to 2.4.3, which matches Security 5.4.5, see Boot dependencies. |
- Spring Security 5.4.5 downgraded nimbus-jose-jwt to 8.+ from 9.+, which breaks NimbusJwsEncoder. - Bump Security to 5.4.5, and Boot to 2.4.3 to match Security
Kehrlann
force-pushed
the
align-nimbus-with-spring-security
branch
from
5d93772 to
cb19670
Compare
|
Thanks for the PR @Kehrlann ! This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which breaks NimbusJwsEncoder.
5.4.4 included) and with 8.+ (in Security 5.4.5), we need to use JSONObjects
from
json-smart, which was bundled with nimbus 8.+ but not with 9.+Tested with both springSecurityVersion = 5.4.2 and 5.4.5
Samples tested with:
closes #256