Skip to content

Incorrect reference to stop method in documentation #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmbenhassine opened this issue Jan 2, 2020 · 1 comment
Closed

Incorrect reference to stop method in documentation #3643

fmbenhassine opened this issue Jan 2, 2020 · 1 comment
Labels
in: documentation status: ideal-for-contribution Issues that are ideal for contribution by the community type: bug
Milestone
4.3.0

Comments

@fmbenhassine
Copy link
Contributor

The section Stopping a Job Manually for Business Reasons has an incorrect reference to a stop method in the JobLauncher interface:

Spring Batch provides a stop() method through the JobLauncher interface, but this is really for use by the operator rather than the application programmer.

JobLauncher has no stop method, the doc should rather say "through the JobOperator interface".
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Jan 2, 2020
@fmbenhassine fmbenhassine added the status: ideal-for-contribution Issues that are ideal for contribution by the community label Jan 2, 2020
@fmbenhassine fmbenhassine removed this from the 4.3.0 milestone Jan 13, 2020
dimitrisli added a commit to dimitrisli/spring-batch that referenced this issue Apr 18, 2020
@dimitrisli
[spring-projects#3643] Fixing documentation typo
9773df2
dimitrisli added a commit to dimitrisli/spring-batch that referenced this issue Apr 18, 2020
@dimitrisli
[spring-projects#3643] Fixing documentation typo
2c350ec
@dimitrisli dimitrisli mentioned this issue Apr 18, 2020
Merged
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone May 15, 2020
fmbenhassine pushed a commit that referenced this issue May 20, 2020
@dimitrisli
Fix typo in documentation
da2a5da 
Issue #3643
@fmbenhassine
Copy link
Contributor Author

Resolved with #3696 .

@fmbenhassine fmbenhassine mentioned this issue May 20, 2020
Closed
@fmbenhassine fmbenhassine changed the title Incorrect reference to stop method in documenation Incorrect reference to stop method in documentation Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: documentation status: ideal-for-contribution Issues that are ideal for contribution by the community type: bug
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
1 participant
@fmbenhassine