-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Meta-annotate @SpringBatchTest with @ExtendWith(SpringExtension.class) #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@benas could I pick this one up? The @ExtendWith() will require junit-jupiter-api dependency, is that ok? |
@dimitrisli I have already a branch for that: https://github.com/benas/spring-batch/tree/GH-3647 (See my WIP here fmbenhassine@2fc8f6e). I just did not open a PR yet. But if you want to do it, go ahead you are welcome! |
Since github added the ability to create draft PRs recently, I created a draft PR for this here: #3697.
@dimitrisli I created the draft PR to avoid duplicate efforts, but feel free to review or test the change. Any contribution is welcome! Thank you upfront. |
@benas no problem at all, please do continue on this |
Similar to how many Spring Boot test annotations are meta-annotated with
@ExtendWith(SpringExtension.class)
-- for example,@SpringBootTest
,@WebMvcTest
, etc.) -- I recommend that@SpringBatchTest
be meta-annotated with@ExtendWith(SpringExtension.class)
in order to simplify configuration when writing tests with JUnit Jupiter.The text was updated successfully, but these errors were encountered: