Skip to content

Meta-annotate @SpringBatchTest with @ExtendWith(SpringExtension.class) #3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbrannen opened this issue Jan 15, 2020 · 4 comments · Fixed by #3697
Closed

Meta-annotate @SpringBatchTest with @ExtendWith(SpringExtension.class) #3647

sbrannen opened this issue Jan 15, 2020 · 4 comments · Fixed by #3697

Comments

@sbrannen
Copy link
Member

Similar to how many Spring Boot test annotations are meta-annotated with @ExtendWith(SpringExtension.class) -- for example, @SpringBootTest, @WebMvcTest, etc.) -- I recommend that @SpringBatchTest be meta-annotated with @ExtendWith(SpringExtension.class) in order to simplify configuration when writing tests with JUnit Jupiter.

@dimitrisli
Copy link
Contributor

@benas could I pick this one up? The @ExtendWith() will require junit-jupiter-api dependency, is that ok?

@fmbenhassine
Copy link
Contributor

fmbenhassine commented Apr 18, 2020

@dimitrisli I have already a branch for that: https://github.com/benas/spring-batch/tree/GH-3647 (See my WIP here fmbenhassine@2fc8f6e). I just did not open a PR yet. But if you want to do it, go ahead you are welcome!

@fmbenhassine
Copy link
Contributor

Since github added the ability to create draft PRs recently, I created a draft PR for this here: #3697.

But if you want to do it, go ahead you are welcome!

@dimitrisli I created the draft PR to avoid duplicate efforts, but feel free to review or test the change. Any contribution is welcome! Thank you upfront.

@dimitrisli
Copy link
Contributor

@benas no problem at all, please do continue on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants