Skip to content

FlatFileItemReaderBuilder reports error "Only one LineTokenizer option may be configured" when none are. #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mminella opened this issue Mar 31, 2020 · 4 comments
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure status: first-timers-only Issues that we would like first-timers only to work on type: bug
Milestone

Comments

@mminella
Copy link
Member

At line 472 of the FlatFileItemReaderBuilder it validates that not multiple LineTokenizers implementations have been configured. However, if the user has not configured one (validatorValue == 0 on that line), they get the same message implying that multiple have been configured. This error message should not be thrown if validatorValue == 0. The case of no LineTokenizer being configured is already handled at line 487 of that class anyways.

@mminella mminella added the status: first-timers-only Issues that we would like first-timers only to work on label Mar 31, 2020
@santfirax
Copy link
Contributor

Hello, I'd like to work on this.

@mminella
Copy link
Member Author

If anyone is interested in working on this, please checkout the contribution guidelines here: https://github.com/spring-projects/spring-batch/blob/master/CONTRIBUTING.md

@santfirax
Copy link
Contributor

santfirax commented Mar 31, 2020

Hello @mminella , can you take a look at this PR? #3689

mminella pushed a commit that referenced this issue Mar 31, 2020
Fixed validation for the FlatFileItemReaderBuilder where no
LineTokenizer had been provided.

Resolves: #3688
mminella pushed a commit that referenced this issue Mar 31, 2020
Fixed validation for the FlatFileItemReaderBuilder where no
LineTokenizer had been provided.

Resolves: #3688
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Mar 31, 2020
@fmbenhassine fmbenhassine added the has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" label Mar 31, 2020
This was referenced Mar 31, 2020
@mminella
Copy link
Member Author

mminella commented Apr 1, 2020

Thanks to @santfirax to addressing this in amazingly fast time! Resolved via #3689

dimitrisli pushed a commit to dimitrisli/spring-batch that referenced this issue Apr 18, 2020
Fixed validation for the FlatFileItemReaderBuilder where no
LineTokenizer had been provided.

Resolves: spring-projects#3688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: infrastructure status: first-timers-only Issues that we would like first-timers only to work on type: bug
Projects
None yet
Development

No branches or pull requests

3 participants