Skip to content

Misleading code example in reference documentation #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JacksonPhoong opened this issue Apr 9, 2020 · 2 comments · Fixed by #3702
Closed

Misleading code example in reference documentation #3692

JacksonPhoong opened this issue Apr 9, 2020 · 2 comments · Fixed by #3702
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: documentation status: first-timers-only Issues that we would like first-timers only to work on type: bug
Milestone
4.3.0

Comments

@JacksonPhoong
Copy link

In the Spring official docs, here, in the Java configuration code under Spring Batch Integration Configuration, there is a typo that is misleading. The handle() should be transform() in the integrationFlow method.

Artem Bilan asked me to raise this issue when I asked him about it on a question in StackOverflow.
@fmbenhassine fmbenhassine added in: documentation status: first-timers-only Issues that we would like first-timers only to work on status: waiting-for-triage Issues that we did not analyse yet type: bug labels Apr 9, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Apr 9, 2020
@fmbenhassine fmbenhassine removed the status: waiting-for-triage Issues that we did not analyse yet label Apr 9, 2020
@charvakcpatel007
Copy link
Contributor

charvakcpatel007 commented Apr 26, 2020 •
edited
Loading

I would like to pick this up
The change will occur in this file https://github.com/spring-projects/spring-batch/blob/master/spring-batch-docs/asciidoc/spring-batch-integration.adoc
on line 326.

@fmbenhassine
Copy link
Contributor

@charvakcpatel007 Thank you for your suggestion to help. If there is no open PR for a ticket, then it is open for contribution. So you are welcome!

charvakcpatel007 added a commit to charvakcpatel007/spring-batch that referenced this issue Apr 27, 2020
@charvakcpatel007
[spring-projects#3692] Fixing Misleading Java code
d485a46
charvakcpatel007 added a commit to charvakcpatel007/spring-batch that referenced this issue Apr 27, 2020
@charvakcpatel007
Misleading Java Code fix in documentation
15e87c9 
Resolves spring-projects#3692
charvakcpatel007 added a commit to charvakcpatel007/spring-batch that referenced this issue Apr 27, 2020
@charvakcpatel007
Fixiing Misleading Java Code in documentation
db31887 
Resolves spring-projects#3692
charvakcpatel007 added a commit to charvakcpatel007/spring-batch that referenced this issue Apr 27, 2020
@charvakcpatel007
Fixing Misleading Java Code in documentation
8f490de 
Resolves spring-projects#3692
@charvakcpatel007 charvakcpatel007 mentioned this issue Apr 27, 2020
Merged
fmbenhassine pushed a commit that referenced this issue May 25, 2020
@charvakcpatel007
Fix misleading Java Code in documentation
7a775cf 
Resolves #3692
@fmbenhassine fmbenhassine changed the title Misleading Java code in Spring official docs Misleading code example in reference documentation May 25, 2020
@fmbenhassine fmbenhassine mentioned this issue May 25, 2020
Closed
fmbenhassine pushed a commit to fmbenhassine/spring-batch that referenced this issue May 25, 2020
@charvakcpatel007 @fmbenhassine
Fix misleading Java Code in documentation
fe222d3 
Resolves spring-projects#3692
@fmbenhassine fmbenhassine added the has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" label May 25, 2020
@fmbenhassine fmbenhassine mentioned this issue May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: documentation status: first-timers-only Issues that we would like first-timers only to work on type: bug
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Fixing Misleading Java Code in documentation charvakcpatel007/spring-batch
3 participants
@fmbenhassine @charvakcpatel007 @JacksonPhoong