Skip to content

Add SynchronizedItemStreamWriter #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Oct 8, 2018 · 7 comments
Closed

Add SynchronizedItemStreamWriter #842

spring-projects-issues opened this issue Oct 8, 2018 · 7 comments

Comments

@spring-projects-issues
Copy link
Collaborator

gd-estrepetov opened BATCH-2762 and commented

This could be useful especially for writers like JsonFileItemWriter.


Affects: 4.1.0

Referenced from: pull request #665

@spring-projects-issues
Copy link
Collaborator Author

Dimitrios Liapis commented

Mahmoud Ben Hassine Would that request make sense? If so I could take a look

@spring-projects-issues
Copy link
Collaborator Author

Mahmoud Ben Hassine commented

Yes, this feature has been discussed on gitter and gd-estrepetov suggested to open a PR for it. This make sense when used with the Json item writer for example (as explained here) and is a nice addition IMO to complement the SynchronizedItemStreamReader.

But everyone is welcome to contribute!

@spring-projects-issues
Copy link
Collaborator Author

Dimitrios Liapis commented

ah sure thanks, I wasn't aware of the gitter channel

of course gd-estrepetov has precedence :)

gd-estrepetov - have you started working on this by any chance?

@spring-projects-issues
Copy link
Collaborator Author

Dimitrios Liapis commented

Just realised that there's been some time since the last update on this issue so I've submitted a PR

#665

In case gd-estrepetov has already started on this I can retract this PR

@spring-projects-issues
Copy link
Collaborator Author

gd-estrepetov commented

Dimitrios Liapis, I am busy at my daily job, so I am good with your PR. You can take this task.

@spring-projects-issues
Copy link
Collaborator Author

Dimitrios Liapis commented

gd-estrepetov many thanks

@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Jan 13, 2020
@fmbenhassine fmbenhassine removed the status: waiting-for-triage Issues that we did not analyse yet label Jan 13, 2020
fmbenhassine pushed a commit to fmbenhassine/spring-batch that referenced this issue May 14, 2020
@fmbenhassine
Copy link
Contributor

Resolved with #665 .

@fmbenhassine fmbenhassine changed the title Add Synchronized version of ItemWriter similar to SynchronizedItemStreamReader [BATCH-2762] Add SynchronizedItemStreamWriter May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants