Add support to build JsonItemReader when no Resource is provided #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded in JsonItemReaderBuilder
|
Hello @benas could it be possible that you review this PR? it would be awesome to receive some feedback and if possible to merge it. |
|
Hi @santfirax , the PR LGTM at first sight. I will let you know when I test it (should be merged in 4.3.0-RC1). |
fmbenhassine
changed the title
|
LGTM. Rebased and merged as c78e2b5. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added Constructor to JsonItemReader class
-Removed assertion not null to resource to allow building a JsonIteamReader without providing one
-Added unit test to build JsonItemReader without a resource
-Deleted assertion to check if a resource was provided