Add JpaCursorItemReader implementation #3775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
force-pushed
the
GH-901
branch
from
dd0d920 to
76d0a7f
Compare
mminella
reviewed
Sep 16, 2020
|
|
||
| /** | ||
| * The {@link EntityManagerFactory} to be used for executing the configured | ||
| * {@link #queryString}. |
There was a problem hiding this comment.
We use this with the QueryProvider approach as well.
| * Create a new {@link JpaCursorItemReader}. | ||
| */ | ||
| public JpaCursorItemReader() { | ||
| setName(ClassUtils.getShortName(JpaCursorItemReader.class)); |
There was a problem hiding this comment.
Why do this if you are going to require a name to be set in the builder?
|
Merged in 4185400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for Issue #901. It adds a cursor-based implementation of an
ItemStreamReaderbased onQuery#getResultStream()which was added in JPA 2.2.The new reader passes the same test suite as other cursor-based implementations.