Issue-3802: make kafkaTemplate field-var accessible in KafkaItemWriter's subcla… #3807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| KafkaItemWriter<String, String> kafkaItemWriter = new KafkaItemWriter<String, String>() { | ||
| @Override | ||
| protected void writeKeyValue(String key, String value) { | ||
| this.kafkaTemplate.flush(); |
There was a problem hiding this comment.
This could be changed to this.kafkaTemplate.sendDefault(key, value);, because currently the parameters are not used. Do you agree?
| }; | ||
| kafkaItemWriter.setKafkaTemplate(kafkaTemplate); | ||
| kafkaItemWriter.writeKeyValue("k", "v"); | ||
| verify(kafkaTemplate).flush(); |
There was a problem hiding this comment.
Related to the previous comment, this should be updated to verify(this.kafkaTemplate).sendDefault("k", "v");.
There was a problem hiding this comment.
makes sense. I'll update the PR
fmbenhassine
added
in: infrastructure
pr-for: enhancement
status: waiting-for-reporter
|
Great! LGTM now. Rebased, squashed and merged as feb46fd. Thank you for your contribution 👍 |
fmbenhassine
removed
the
status: waiting-for-reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3802
Added test to prevent future reversion of this change