Skip to content

Conversation

kirkster96
Copy link
Contributor

I noticed that on previous pages, methods with return type Job were being annotated with @Bean.
I assume this is meant to be a Spring Bean in this example.

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

I noticed that on previous pages, methods with return type Job were being annotated with `@Bean`. I assume this is missing.
fmbenhassine pushed a commit that referenced this pull request May 13, 2024
fmbenhassine pushed a commit that referenced this pull request May 13, 2024
@fmbenhassine
Copy link
Contributor

Good catch! Merged as b06f90a. Thank you for the fix.

@fmbenhassine fmbenhassine added pr-for: bug in: documentation for: backport-to-5.0.x Issues that will be back-ported to the 5.0.x line for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line labels May 13, 2024
fmbenhassine added a commit that referenced this pull request May 13, 2024
Cherry-picked from b06f90a

Issue #4591
This was referenced May 13, 2024
natedanner pushed a commit to natedanner/spring-projects__spring-batch that referenced this pull request May 20, 2024
FBibonne pushed a commit to FBibonne/spring-batch that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: backport-to-5.0.x Issues that will be back-ported to the 5.0.x line for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: documentation pr-for: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants