Skip to content

[BATCH-2741] Fix issue - job parameter overwrites #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jojoldu
Copy link
Contributor

@jojoldu jojoldu commented Aug 8, 2018

Hello?
I recently updated SpringBoot 2.0 with Spring Batch 4.0.
But I think there is a bug.
If the job fails, I keep getting the value of the failed Job Parameter even if I change the value of the Job Parameter with the same key next time.
In 1.5.x, I confirmed that it did not happen, and when I checked the code, it showed a bug in the code and sent a PR

@jojoldu jojoldu changed the title Fixed issue - job parameter overwrites Fix issue - job parameter overwrites Aug 10, 2018
@jojoldu jojoldu changed the title Fix issue - job parameter overwrites [BATCH-2741] Fix issue - job parameter overwrites Sep 6, 2018
@fmbenhassine fmbenhassine self-requested a review October 10, 2018 20:22
@fmbenhassine
Copy link
Contributor

As explained in BATCH-2711, the method JobParametersBuilder#getNextJobParameters should not deal with restartability anymore after it has been moved to Spring Batch in order to be consistent with CommandLineJobRunner and JobOperator. So the fix in this PR cannot be applied since the method will still deal with restartability. The issue is deeper than just fixing the merge method as in this PR, it should be fixed in both Spring Batch and Spring Boot.

Thank you @jojoldu for your contribution anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants