Allow whitespace characters as delimiters in FlatFileItemReader #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mminella
reviewed
Aug 14, 2018
| public void testSimpleDelimitedWithTabCharacter() throws Exception { | ||
| FlatFileItemReader<Foo> reader = new FlatFileItemReaderBuilder<Foo>() | ||
| .name("fooReader") | ||
| .resource(getResource("1 2 3")) |
There was a problem hiding this comment.
Please replace the tab with \t so that it is explicit.
There was a problem hiding this comment.
I agree! Fixed.
fmbenhassine
force-pushed
the
BATCH-2738
branch
from
de65d43 to
fe1aef3
Compare
Resolves BATCH-2738
|
Got the same issue with \t. |
|
@dieegorenan Do you mean you still have an issue using |
|
@benas I meant that this will solve my issue as well. Thank you for the PR. 🙂 |
|
LGTM. Rebased and merged as 80d1a24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves BATCH-2738