Allow the transaction manager to be overridden in DefaultBatchConfigurer #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
force-pushed
the
BATCH-2294
branch
from
142f1d8 to
78ca691
Compare
mminella
reviewed
Aug 31, 2018
|
|
||
| @Test | ||
| public void testConfigurationWithNoDataSourceAndNoTransactionManager() throws Exception { | ||
| AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext(BatchConfigurationWithNoDataSourceAndNoTransactionManager.class); |
There was a problem hiding this comment.
Nit pick...no reason to code to the implementation in these methods
There was a problem hiding this comment.
I agree. Fixed.
Before this commit, it was not possible to override the transaction manager by subclassing DefaultBatchConfigurer and overriding the getTransactionManager method. This commit uses the getTransactionManager method in the initialize method in order to take into account the transaction manager provided by the user. Resolves BATCH-2294
fmbenhassine
force-pushed
the
BATCH-2294
branch
from
78ca691 to
78447aa
Compare
|
LGTM. Rebased and merged as a68d700. |
This was referenced Aug 31, 2018
|
Isn't this solution problematic as long as SimpleBatchConfiguration keeps the part? |
|
|
pranav-patil
referenced
this pull request
in pranav-patil/spring-kubernetes-microservices
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it was not possible to override the transaction manager by subclassing
DefaultBatchConfigurerand overriding thegetTransactionManagermethod.This commit uses the
getTransactionManagermethod in theinitializemethod in order to take into account the transaction manager provided by the user.Resolves BATCH-2294