Make JobParametersBuilder#getNextJobParameters consistent with CommandLineJobRunner and JobOperator #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dLineJobRunner and JobOperator Before this commit, JobParametersBuilder#getNextJobParameters was checking for restartability conditions. This is not only already done by the JobLauncher, but also makes it inconsistent with the behaviour of CommandLineJobRunner when used with "-next" option and JobOperator#startNextInstance, which is starting the next instance in sequence based on the incrementer without dealing with restartability. This commit fixes the JobParametersBuilder#getNextJobParameters to behave like the CommandLineJobRunner and JobOperator in regards to starting the next instance. Resolves BATCH-2711
This was referenced Oct 23, 2018
|
Any chance of merging this soon? I'd like to get the Spring Boot PR in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves BATCH-2711.
Before this commit,
JobParametersBuilder#getNextJobParameterswas checking for restartability conditions. This is not only already done by theJobLauncher, but also makes it inconsistent with the behaviour ofCommandLineJobRunnerwhen used with "-next" option andJobOperator#startNextInstance, which is starting the next instance in sequence based on the incrementer without dealing with restartability.This commit fixes the
JobParametersBuilder#getNextJobParametersto behave like theCommandLineJobRunnerandJobOperatorin regards to starting the next instance.This PR is coupled with another PR against boot. Both PRs should be merged together to correctly fix the issue.