BATCH-2849 Account For Different Whitespaces In Keyword Removal #738
Conversation
Modify `removeKeyWord(...)` such that the keyword is removed regardless of what kind of whitespace follows. This is especially useful for those who read in SQL from a file which has been formatted such that keywords live on their own lines. Added unit tests for trimming whitespace.
|
Hello @benas. I notice you are the one marking most of the recent pull requests as ready to review etc. I'm just wondering if I missed a step in the contribution guidelines. If it's just a case of this being a low priority change for a relatively infrequent use case that's fine. I just wanted to make sure that I didn't forget something. |
|
Thank you for the PR! I will let you know in which release BATCH-2849 will be included.
The PR LGTM at first glance. Don't hesitate to update the year in the license header and add your name to the authors list, see: https://github.com/spring-projects/spring-batch/blob/master/CONTRIBUTING.md#update-license-header-to-modified-files-as-necessary |
|
Thank you! |
fmbenhassine
added
in: infrastructure
pr-for: bug
and removed
pr-for: enhancement
labels
fmbenhassine
added
the
has: backports
...ava/org/springframework/batch/item/database/support/AbstractSqlPagingQueryProviderTests.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/batch/item/database/support/AbstractSqlPagingQueryProviderTests.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/batch/item/database/support/AbstractSqlPagingQueryProvider.java
Outdated
Show resolved
Hide resolved
fmbenhassine
added
the
status: waiting-for-reporter
Modify test variable names in tests to be more clear. Update copyright year to 2020.
fmbenhassine
removed
the
status: waiting-for-reporter
|
LGTM now. Rebased, squashed and merged as 7f01bf7. Thank you! |
Modify
removeKeyWord(...)such that the keyword is removed regardlessof what kind of whitespace follows. This is especially useful for those
who read in SQL from a file which has been formatted such that keywords
live on their own lines.
Add unit tests for trimming whitespace.
Resolves BATCH-2849