Skip to content

Update schema-appendix.adoc to fix wrong names #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Update schema-appendix.adoc to fix wrong names #748

merged 1 commit into from
Mar 3, 2020

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 29, 2019

BATCH_EXECUTION_CONTEXT should be BATCH_JOB_EXECUTION_PARAMS
EXECUTION_ID should be JOB_EXECUTION_ID

Please check Frequency if it's up to date.

@fmbenhassine
Copy link
Contributor

Is this related to https://jira.spring.io/browse/BATCH-2853?

@quaff
Copy link
Contributor Author

quaff commented Nov 29, 2019

@benas Yes.

@fmbenhassine
Copy link
Contributor

ok thanks, I added a link to this PR in BATCH-2853.

@fmbenhassine fmbenhassine added status: waiting-for-triage Issues that we did not analyse yet and removed pr-status: ready-to-review labels Jan 13, 2020
@fmbenhassine fmbenhassine added has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: documentation pr-for: bug and removed status: waiting-for-triage Issues that we did not analyse yet labels Feb 28, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Feb 28, 2020
@fmbenhassine
Copy link
Contributor

fmbenhassine commented Feb 28, 2020

BATCH_EXECUTION_CONTEXT should be BATCH_JOB_EXECUTION_PARAMS

This is actually not correct. BATCH_EXECUTION_CONTEXT has been replaced with BATCH_STEP_EXECUTION_CONTEXT and BATCH_JOB_EXECUTION_CONTEXT in d272105#diff-9df3d792ac9c1d09e598d04018ee1f6eL71-L80. And based on the frequency "On commit interval, a.k.a. chunk" mentioned in the appendix, it is definitely not BATCH_JOB_EXECUTION_PARAMS: this table is not queried/updated at each commit interval. It is BATCH_STEP_EXECUTION_CONTEXT that is updated at this frequency, here is an excerpt from the ExecutionContext section:

They are two different ExecutionContexts.
The one scoped to the Step is saved at every commit point in the Step,
whereas the one scoped to the Job is saved in between every Step execution.

@quaff Could you please update the PR accordingly?

@fmbenhassine fmbenhassine added the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Feb 28, 2020
@quaff
Copy link
Contributor Author

quaff commented Mar 2, 2020

@benas BATCH_STEP_EXECUTION_CONTEXT and BATCH_STEP_EXECUTION_CONTEXT are queried by primary key, so they should be excluded from this table.

BATCH_EXECUTION_CONTEXT is obsoleted
@fmbenhassine fmbenhassine removed the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Mar 2, 2020
@fmbenhassine fmbenhassine merged commit 6103fe7 into spring-projects:master Mar 3, 2020
@fmbenhassine
Copy link
Contributor

Indeed, BATCH_STEP_EXECUTION_CONTEXT and BATCH_JOB_EXECUTION_CONTEXT are queried by primary keys (which are indexed by default), so this entry can be removed from the table. Thanks for the PR!

@quaff quaff deleted the patch-8 branch March 4, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: documentation pr-for: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants