Skip to content

Commit ae941c0

Browse files
committed
Merge pull request #29200 from hpoettker
* pr/29200: Adjust IDENTITY in DDLs for H2 2.x compatibility Closes gh-29200
2 parents 37c1f47 + e3d0f1f commit ae941c0

File tree

12 files changed

+22
-20
lines changed

12 files changed

+22
-20
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/resources/city-schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
CREATE TABLE CITY (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30),
44
state VARCHAR(30),
55
country VARCHAR(30),

spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/r2dbc/ConnectionFactoryHealthIndicatorTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -98,9 +98,11 @@ void healthIndicatorWhenDatabaseUpWithSuccessValidationQuery() {
9898
CloseableConnectionFactory connectionFactory = createTestDatabase();
9999
try {
100100
String customValidationQuery = "SELECT COUNT(*) from HEALTH_TEST";
101-
Mono.from(connectionFactory.create()).flatMapMany((it) -> Flux
102-
.from(it.createStatement("CREATE TABLE HEALTH_TEST (id INTEGER IDENTITY PRIMARY KEY)").execute())
103-
.flatMap(Result::getRowsUpdated).thenMany(it.close())).as(StepVerifier::create).verifyComplete();
101+
String createTableStatement = "CREATE TABLE HEALTH_TEST (id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY)";
102+
Mono.from(connectionFactory.create())
103+
.flatMapMany((it) -> Flux.from(it.createStatement(createTableStatement).execute())
104+
.flatMap(Result::getRowsUpdated).thenMany(it.close()))
105+
.as(StepVerifier::create).verifyComplete();
104106
ReactiveHealthIndicator healthIndicator = new ConnectionFactoryHealthIndicator(connectionFactory,
105107
customValidationQuery);
106108
healthIndicator.health().as(StepVerifier::create).assertNext((actual) -> {

spring-boot-project/spring-boot-autoconfigure/src/test/resources/batch/custom-schema.sql

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
CREATE TABLE PREFIX_JOB_INSTANCE (
2-
JOB_INSTANCE_ID BIGINT IDENTITY NOT NULL PRIMARY KEY ,
2+
JOB_INSTANCE_ID BIGINT GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY ,
33
VERSION BIGINT ,
44
JOB_NAME VARCHAR(100) NOT NULL,
55
JOB_KEY VARCHAR(32) NOT NULL,
66
constraint JOB_INST_UN unique (JOB_NAME, JOB_KEY)
77
) ;
88

99
CREATE TABLE PREFIX_JOB_EXECUTION (
10-
JOB_EXECUTION_ID BIGINT IDENTITY NOT NULL PRIMARY KEY ,
10+
JOB_EXECUTION_ID BIGINT GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY ,
1111
VERSION BIGINT ,
1212
JOB_INSTANCE_ID BIGINT NOT NULL,
1313
CREATE_TIME TIMESTAMP NOT NULL,
@@ -36,7 +36,7 @@ CREATE TABLE PREFIX_JOB_EXECUTION_PARAMS (
3636
) ;
3737

3838
CREATE TABLE PREFIX_STEP_EXECUTION (
39-
STEP_EXECUTION_ID BIGINT IDENTITY NOT NULL PRIMARY KEY ,
39+
STEP_EXECUTION_ID BIGINT GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY ,
4040
VERSION BIGINT NOT NULL,
4141
STEP_NAME VARCHAR(100) NOT NULL,
4242
JOB_EXECUTION_ID BIGINT NOT NULL,
@@ -75,11 +75,11 @@ CREATE TABLE PREFIX_JOB_EXECUTION_CONTEXT (
7575
) ;
7676

7777
CREATE TABLE PREFIX_STEP_EXECUTION_SEQ (
78-
ID BIGINT IDENTITY
78+
ID BIGINT GENERATED BY DEFAULT AS IDENTITY
7979
);
8080
CREATE TABLE PREFIX_JOB_EXECUTION_SEQ (
81-
ID BIGINT IDENTITY
81+
ID BIGINT GENERATED BY DEFAULT AS IDENTITY
8282
);
8383
CREATE TABLE PREFIX_JOB_SEQ (
84-
ID BIGINT IDENTITY
84+
ID BIGINT GENERATED BY DEFAULT AS IDENTITY
8585
);

spring-boot-project/spring-boot-autoconfigure/src/test/resources/data-city-schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
CREATE TABLE CITY (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30),
44
state VARCHAR(30),
55
country VARCHAR(30),
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
CREATE TABLE SPAM (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30)
44
);
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
CREATE TABLE FOO (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
todrop VARCHAR(30)
44
);
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
CREATE TABLE FOO (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30)
44
);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
CREATE TABLE BAR (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30)
44
);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
CREATE TABLE FOO (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30)
44
);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
CREATE TABLE EXAMPLE (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30)
44
);
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
CREATE TABLE CUSTOMER (
2-
ID INTEGER IDENTITY PRIMARY KEY,
2+
ID INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
FIRST_NAME VARCHAR(30),
44
DATE_OF_BIRTH DATE
55
);

spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-data-r2dbc/src/main/resources/schema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
CREATE TABLE CITY (
2-
id INTEGER IDENTITY PRIMARY KEY,
2+
id INTEGER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
33
name VARCHAR(30),
44
state VARCHAR(30),
55
country VARCHAR(30)

0 commit comments

Comments
 (0)