Skip to content

Adjust test schema DDLs for compatibility with H2 2.x #29200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adjust test schema DDLs for compatibility with H2 2.x #29200

wants to merge 1 commit into from

Conversation

hpoettker
Copy link
Contributor

This PR is related to #29034 and shall help to support H2 v2.0.x with Spring Boot. It adjusts all DDLs for tests such that the syntax is compatible not only with HSQL and H2 v1.4.x but also H2 v2.0.x.

I renamed the schema file for the Spring Batch autoconfiguration tests as H2 and not HSQL is actually used during the tests.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2022
snicoll
snicoll requested changes Jan 5, 2022
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but I don't understand why you've switched some of the tests from HSQL to H2.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jan 5, 2022
@hpoettker
Copy link
Contributor Author

hpoettker commented Jan 5, 2022 •
edited
Loading

I now removed the suffix -hsql from the custom schema file for the Spring Batch autoconfiguration tests. The actually used DB is not important for the tests that use the file and it currently suggests that HSQL is used although it is not.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 5, 2022
This was referenced Jan 10, 2022
Closed
Closed
@hpoettker hpoettker requested a review from snicoll January 12, 2022 10:36
@snicoll snicoll self-assigned this Feb 4, 2022
@snicoll snicoll mentioned this pull request Feb 4, 2022
Closed
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 4, 2022
@snicoll snicoll added this to the 2.7.0-M2 milestone Feb 4, 2022
@snicoll snicoll changed the title Adjust test schema DDLs for compatibility with H2 2.0.x Adjust test schema DDLs for compatibility with H2 2.x Feb 4, 2022
snicoll pushed a commit that referenced this pull request Feb 4, 2022
@hpoettker @snicoll
Adjust IDENTITY in DDLs for H2 2.x compatibility
e3d0f1f 
See gh-29200
@snicoll snicoll closed this in ae941c0 Feb 4, 2022
@snicoll
Copy link
Member

snicoll commented Feb 4, 2022

Thanks a lot @hpoettker

@hpoettker hpoettker deleted the h2-v2-compatibility branch February 4, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.7.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@hpoettker @snicoll @spring-projects-issues