Regression (between 1.0.2 and 1.1.3) when building a spring-boot JAR with gradle. External JAR file is not embedded.

[dam5s]

There seems to be a regression from spring-boot plugin 1.0.2.RELEASE to 1.1.3.RELEASE.

I have a project including a local jar file as follows:

dependencies {
  compile 'org.springframework.boot:spring-boot-starter-web:' + springBootVersion
  compile files("$rootDir/vendor/foo.jar")
}

When building with plugin 1.0.2.RELEASE, the jar is correctly embedded, and starting my server doesn't throw an error.

When building with plugin 1.1.3.RELEASE, the jar is not included, and starting my server through the built jar will throw a ClassNotFoundException when referring a class from foo.jar

[wilkinsona]

The problem's caused by the move to working with ResolvedArtifacts rather than simply treating the configurations as FileCollections and iterating over their Files.

As far as I can tell, it's impossible to get hold of a dependency declared using files as a ResolvedArtifact. This will get hold of each file dependency in the compile configuration:

configurations.compile.incoming.dependencies.findAll{ it instanceof FileCollectionDependency }.each { println it.resolve() }

It looks like we need to change LibraryCallback or we could wrap each FileCollectionDependency in a dummy ResolvedArtifact.

@philwebb Can you see a more elegant solution?

[philwebb]

@wilkinsona I've updated ProjectLibraries to adapt dependencies to Library instances earlier. We can then add items for both ResolvableArtifact and Files. Hopefully that fixes it without causing any unexpected regressions.