ReactiveSecurityAutoConfiguration is missing conditions

[snicoll]

It only does an import of another class that has some conditions on them. That looks weird to me. It should at the very least check Spring Security and Project reactor

[snicoll]

I don't understand why ReactiveUserDetailsServiceAutoConfiguration is a separate auto-config. It looks like both this class and WebFluxSecurityConfiguration could be imported by what is current ReactiveSecurityAutoConfiguration and their basic conditions should move there.

Also a condition on reactor should be added as it less costly than checking the web application type.

[mbhave]

@snicoll ReactiveUserDetailsServiceAutoConfiguration was pulled into a separate auto-config for this purpose.

I think we can the conditionals and configuration from WebFluxSecurityConfiguration to ReactiveSecurityAutoConfiguration instead of the single import.

I can't remember if there was a reason why ReactiveUserDetailsServiceAutoConfiguration is @ConditionalOnWebApplication because from what @wilkinsona pointed out here, it doesn't need to be.

[ayudovin]

Does it mean that
@Configuration
@EnableWebFluxSecurity
static class EnableWebFluxSecurityConfiguration {}
also should be located in ReactiveSecurityAutoConfiguration ?

[snicoll]

@ayudovin You are correct. Madhura and I just discussed this one and I think we have this covered. I am assigning Madhura so that work is not duplicated.

[ayudovin]

@snicoll, ok