SpringApplication.setApplicationContextClass does not correctly deduce REACTIVE type

[dsyer]

This appears not to cause any problems with existing applications, but it seems inconsistent and results in a SpringApplication having webApplicationType=NONE in an integration test (per the logic in setApplicationContextClass() which is called by the test context loader).

[wilkinsona]

GenericReactiveWebApplicationContext is not a WebApplicationContext

This is by design. WebApplicationContext is coupled to the Servlet API.

results in a SpringApplication having webApplicationType=NONE in an integration test

I don’t think this is deliberate and reminds me of a discussion we had recently (this issue may be a duplicate). I’ll repurpose the issue to tackle this part for now.

[wilkinsona]

I’ve labelled for team attention to see if anyone else can recall the issue that this one may duplicate.

[philwebb]

We had a discussion recently about the fact ConfigurableReactiveWebEnvironment is used inOnWebApplicationCondition but we didn't support it in the EnvironmentConverter (#13977).

[philwebb]

@dsyer have you got an example test we can run for this one?

[dsyer]

Is the reason for the current behaviour that an integration text uses a mock server by default (not a full HTTP stack)? I think the context class ends up as GenericReactiveWebApplicationContext instead of ReactiveWebServerApplicationContext or something? To me that is still not "NONE", but it's also somewhere in between "NONE" and "REACTIVE" in the way it behaves when the context is created.

[dsyer]

have you got an example test we can run for this one?

Duh. I was wrong about the test context - it was me setting the application context class in a spring.factories listener - so wrong about the mock server as well. But the logic is still wrong in SpringApplication I think - a reactive web application type gets converted to "NONE".

[philwebb]

@dsyer You mean in this method or something else?

[dsyer]

No, sorry this one