Skip to content

Add Java 13 CI #16970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue May 25, 2019 · 4 comments
Closed

Add Java 13 CI #16970

snicoll opened this issue May 25, 2019 · 4 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.2.0.M5

Comments

@snicoll
Copy link
Member

snicoll commented May 25, 2019

We need to update CI to build against Java 13 as well.

I also noticed quite by accident that -Xverify:none and -noverify are going to be deprecated in this release. We have several places where this is used so we should decide what to do there.
@snicoll snicoll added the type: task A general task label May 25, 2019
@snicoll snicoll added this to the 2.x milestone May 25, 2019
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label May 28, 2019
@philwebb philwebb changed the title Support Java 13 Add Java 13 CI May 29, 2019
@philwebb philwebb modified the milestones: 2.x, 2.2.x May 29, 2019
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label May 29, 2019
@philwebb philwebb mentioned this issue May 29, 2019
Closed
@snicoll
Copy link
Member Author

snicoll commented Jun 3, 2019

Rampdown phase two is scheduled for mid-July so let's resume work on this one around that time.

@snicoll snicoll added the status: blocked An issue that's blocked on an external project change label Jun 3, 2019
@snicoll snicoll mentioned this issue Jul 17, 2019
Closed
snicoll added a commit to snicoll/spring-boot that referenced this issue Jul 22, 2019
@snicoll
Add Java 13 CI
da53470 
Closes spring-projectsgh-16970
snicoll added a commit that referenced this issue Jul 23, 2019
@snicoll
Add Java 13 CI
f45d68d 
Closes gh-16970
snicoll added a commit that referenced this issue Jul 23, 2019
@snicoll
Add Java 13 CI
4137320 
Closes gh-16970
@snicoll
Copy link
Member Author

snicoll commented Jul 23, 2019

There are some Hazelcast tests failing on Java 13, I've opened hazelcast/hazelcast#15348

snicoll added a commit that referenced this issue Jul 23, 2019
@snicoll
Add Java 13 CI
63ade1a 
Closes gh-16970
snicoll added a commit that referenced this issue Jul 23, 2019
@snicoll
Add Java 13 CI
e1b5fa5 
Closes gh-16970
@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label Jul 24, 2019
@snicoll snicoll self-assigned this Jul 24, 2019
@snicoll
Copy link
Member Author

snicoll commented Jul 24, 2019

Next up is the tests of the Gradle plugin that are failing with Java 13:

 java.lang.IllegalArgumentException: Unsupported class file major version 57
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:184)
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:166)
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:152)
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:273)
  	at org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:81)
  	at org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
  	at org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
  	at org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
  	at org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)

snicoll added a commit that referenced this issue Jul 24, 2019
@snicoll
Update multi release test jar to include Java 12
19eaf86 
See gh-16970
snicoll added a commit that referenced this issue Jul 24, 2019
@snicoll
Skip Gradle Plugin test when building with JDK 13
f3a138d 
See gh-16970
snicoll added a commit that referenced this issue Jul 24, 2019
@snicoll
Add Java 13 CI
c645ac2 
Closes gh-16970
@philwebb
Copy link
Member

gradle/gradle#8681

@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M5 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.2.0.M5
Development

No branches or pull requests
2 participants
@snicoll @philwebb