-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Immutable configuration properties not shown by Actuator #18636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oops. Thanks for the report! |
@snicoll is this feasible for contribution? I have used actuator endpoint before; however, I don't know how it works under the hood. I am curious how complicated is this task? If open for contribution, I would love to give it a shot. I would appreciate some direction in the form of guidance, previous issues/PRs I could look into, materials, classes, etc. |
@rhamedy it's really hard to answer such question without looking at the actual problem and often we have the solution by the time we're experimenting. This one is extra special as it's assigned to If you have time short term, I believe the problem is this method that serializes the content of the configuration properties instance. For some reason that doesn't work if there isn't a setter? Wild guess, I haven't looked at it in more details. If you want to contribute, we have an |
@snicoll I think we can use other conversion methods here. |
Thank you both ( I think |
This commit updates the configprops actuator endpoint to detect configuration properties that are bound using a constructor. See spring-projectsgh-18636
I've started to hack on something in 353a30f and I've discovered some potential improvements in constructor binding in the process (#18685). I have something somewhat satisfactory except that nested types are not processed. It looks like Jackson decides that there is nothing do as there are no properties or something like that? There is a test failing on that commit. |
Uh oh!
There was an error while loading. Please reload this page.
From my initial test drive of the freshly released Spring Boot 2.2.0.RELEASE it seems that
@ConfigurationProperties
beans declared as immutable with@ConstructorBinding
show up empty in the Actuatorconfigprops
endpoint.Example:
The beans are however correctly bound and their use in other beans is not impacted.
Normal, mutable beans are correctly displayed with their attributes.
Example:
The text was updated successfully, but these errors were encountered: