Skip to content

Support @Timed annotation for WebFlux #18680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lbilger opened this issue Oct 21, 2019 · 7 comments
Closed

Support @Timed annotation for WebFlux #18680

lbilger opened this issue Oct 21, 2019 · 7 comments
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@lbilger
Copy link

lbilger commented Oct 21, 2019

We recently switched an application from WebMvc to WebFlux. We used the @Timed annotation on our controller methods to get custom timing metrics with custom percentiles. After switching to WebFlux, this stopped working. There is the default metric created by the MetricsWebFilter, but I couldn't find a way to configure the percentiles recorded.

It would be great if you could also support the @Timed annotation for WebFlux for maximum flexibility.
Alternatively, it would also help us if we could globally configure the percentiles for the timer recorded by the MetricsWebFilter.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 21, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2019
@philwebb philwebb added this to the 2.x milestone Dec 2, 2019
anshlykov added a commit to anshlykov/spring-boot that referenced this issue Aug 27, 2020
@anshlykov
Support @timed annotation for WebFlux
6a65e11 
Closes spring-projects#18680
anshlykov added a commit to anshlykov/spring-boot that referenced this issue Aug 27, 2020
@anshlykov
Support @timed annotation for WebFlux
fc82ca4 
See spring-projects#18680
@anshlykov anshlykov mentioned this issue Aug 27, 2020
Closed
@Vakhturov
Copy link

Vakhturov commented Oct 19, 2020 •
edited by snicoll
Loading

Hi team, could anyone please clarify the status of this issue?
The linked PR looks good and nothing seems be prevent this from merging, but there is no update since August.

@wilkinsona
Copy link
Member

@Vakhturov Unfortunately, we haven't had time to review the pull request yet. We'd like to get the changes into a 2.x release but it's unlikely to be in 2.4.x which RCs tomorrow.

@patpatpat123

This comment has been minimized.

Sign in to view
@shakuzen shakuzen mentioned this issue Dec 14, 2020
Closed
@snicoll

This comment has been minimized.

Sign in to view
@izeye
Copy link
Contributor

izeye commented Apr 15, 2021

This seems to be resolved via #23112.

@wilkinsona
Copy link
Member

Yes indeed. Thanks, @izeye.

@wilkinsona wilkinsona removed this from the 2.x milestone Apr 15, 2021
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Apr 15, 2021
@patpatpat123
Copy link

Many thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support @Timed annotation for WebFlux anshlykov/spring-boot
8 participants
@snicoll @philwebb @wilkinsona @izeye @lbilger @Vakhturov @spring-projects-issues @patpatpat123