Review configuration options for Spring Data Neo4j

[steffen-harbich-cognitum]

Neo4j OGM allows to configure "use-strict-querying", see neo4j/neo4j-ogm#651. For now, there is no easy way to configure this option using Spring Boot. It would be nice to have a property "spring.data.neo4j.use-strict-querying" as implemented for other properties like uri, username, password or auto-index. See Neo4jDataAutoConfiguration and Neo4jProperties.

There are also other properties I would like to see easily configurable, for example "useNativeTypes". See org.neo4j.ogm.config.Configuration.Builder for what's currently available.

Workaround/hack using reflection:

@Bean
public SessionFactory sessionFactory(org.neo4j.ogm.config.Configuration configuration) 
        throws IllegalAccessException {

    FieldUtils.writeDeclaredField(configuration, "useStrictQuerying", Boolean.TRUE, true);

    SessionFactory sessionFactory = new SessionFactory(configuration, "com.example");
    return sessionFactory;
}

[wilkinsona]

Neo4j OGM allows to configure "use-strict-querying"

Thanks for the suggestion. I think we'd also need to consider use-relaxed-querying as well, particularly as strict querying will become the default in 4.0 and users may want to switch back to relaxed.

@michael-simons Would a spring.data.neo4j.querying property that takes a enum with STRICT and RELAXED values make sense here? We could default to RELAXED and then, when we upgrade to 4.0, flip the default to STRICT.

There are also other properties I would like to see easily configurable, for example "useNativeTypes"

With thanks to @michael-simons , we added the spring.data.neo4j.use-native-types property for this in Spring Boot 2.2.

[michael-simons]

Thanks for looping us in, Andy!

The enum would be nice, yes.

Regarding the flip to 4.0: We have a bigger PR incoming in regards of SDN 6. That property will not be needed anymore (or supported, as a matter of fact).

[wilkinsona]

Thanks, Michael. Will SDN 6 be part of Spring Data 2020.0 (Ockham)? Boot 2.4 will ship with Spring Data 2020.0 so there may be no point in us adding a querying property only to need to remove it again during 2.4's development when SDN 6 lands.

[michael-simons]

Yes. Also: Agree.

[wilkinsona]

Thanks, @michael-simons. Ok, let's keep this one open for now. We can use it to remind us to revisit the configuration properties that we provide and to make sure they we've covered everything that we want to cover once the SDN 6 upgrade has happened