The default value of refresh policy for reactive ES template should be null or false

[ToffeeLu]

Check spring-projects/spring-data-elasticsearch#2110 for details

[mhalbritter]

As @sothawo said, you're right, and this is a breaking change. We can change this in the next release. Adding it to the documentation should be easier, though. I've created ticket #30103 for this.

[mhalbritter]

We should remove the set-calls in the auto-configuration and rely on Spring Data's defaults.

[wilkinsona]

We can remove this set call as a task in 2.5.x:

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchDataConfiguration.java

Line 111 in 44f71a4

template.setRefreshPolicy(RefreshPolicy.IMMEDIATE);

The default is already RefreshPolicy.IMMEDIATE so it is redundant. Removing it will allow us to automatically pick up any future change in Spring Data Elasticsearch.

This set call is a bit trickier:

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/elasticsearch/ElasticsearchDataConfiguration.java

Line 110 in 44f71a4

template.setIndicesOptions(IndicesOptions.strictExpandOpenAndForbidClosed());

Here we have a different default to Spring Data Elasticsearch. I think we should align but we need to decide when to do that.

We may also want to offer configuration properties for the template’s settings to make the defaults easier to change without defining a new bean.

[sothawo]

Another info, I still have to see how this default setting and a change affects this: When using the operations, i.e. the "low level" operation the default should be to not set anything and so use Elasticsearch 's default (which is not immediate). A user that saves an entity and directly needs it to be accessible would then have to either set the refresh policy or do an explicit refresh() call before doing a search()

But when using the higher level repository functions the user expects the data to be available after a save. There used to be an explicit call to refresh after writing operations, I think I changed that to do the writing operations with immediate refresh when called from the repository implementation.

That's nothing that is of your concern, but I think I need to add some detailed information to our docs in Spring Data Elasticsearch .

[ToffeeLu]

I think I need to add some detailed information to our docs in Spring Data Elasticsearch

Really appreciate!
That's exactly what I want! It doesn't matter what's the default value is, because there always some tradeoff, but user need to know.

[snicoll]

@wilkinsona I am trying to see if I can help but I don't know why it was flagged for team attention.