Make the structure of the Undertow support and the structure of the Tomcat and Jetty support consistent #3016
Comments
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
for: team-attention
philwebb
removed
the
for: team-attention
|
Paging @bclozel as I think we might have fixed this one in the meantime. |
wanger26
added a commit
to wanger26/spring-boot
that referenced
this issue
Mar 12, 2024
- getUndertow() to UndertowWebServer will be null until the server has been started. Issue spring-projects#3016 would enable getUndertow() to behave in a similar way to getTomcat() on TomcatWebServer. spring-projects#39839 Signed-off-by: Jakob Wanger <[email protected]>
wanger26
added a commit
to wanger26/spring-boot
that referenced
this issue
Mar 13, 2024
- getUndertow() to UndertowWebServer will be null until the server has been started. Issue spring-projects#3016 would enable getUndertow() to behave in a similar way to getTomcat() on TomcatWebServer. spring-projects#39839 Signed-off-by: Jakob Wanger <[email protected]>
mhalbritter
pushed a commit
that referenced
this issue
Mar 13, 2024
getUndertow() to UndertowWebServer returns null until the server has been started. Issue #3016 would enable getUndertow() to behave in a similar way to getTomcat() on TomcatWebServer. Signed-off-by: Jakob Wanger <[email protected]> See gh-39916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both
JettyEmbeddedServletContainerFactoryandTomcatEmbeddedServletContainerFactoryhave very few fields and the customisation required to apply the configuration inServerProperties.JettyandServerProperties.Tomcatis applied using customisers. In comparison,UndertowEmbeddedServletContainerFactorycontains numerous fields that duplicate those inServerProperties.Undertowand it handles its own customisation.I think this inconsistency should be removed, and I think that should happen by changing the Undertow support to align with the Jetty and Tomcat support. At the same time, we could consider moving the customisation logic out of
ServerProperties.JettyandServerProperties.Tomcatinto separate classes still in thespring-boot-autoconfiguremodule.The text was updated successfully, but these errors were encountered: