Skip to content

Missing configuration processing for PartEvent support #37642

@kzander91

Description

@kzander91

Neither the Javadoc of ReactiveMultipartProperties (spring.webflux.multipart configuration namespace) nor the reference documentation have been updated with info about PartEvent support.
I'm currently trying to switch my controller methods from @RequestBody Flux<Part> to @RequestBody Flux<PartEvent> and stumbled upon the following issues:

  • spring.webflux.multipart.max-parts has no effect when using PartEvent. This is not mentioned in the docs.
  • When using PartEvent, spring.webflux.multipart.max-in-memory-size only affects form parts. The size of file parts cannot be limited with this property (or any other property).
    The Javadoc of this property states that the value is used as a threshold before storing files to disk, which is incorrect when using PartEvent where files are never stored on disk.
  • Several properties say "Ignored when streaming is enabled", but since Remove spring.webflux.multipart.streaming property #32658 there is no way to enable/disable streaming. If using PartEvent is considered to be the new "streaming", the documentation should mention that.

I have opened a companion issue in spring-projects/spring-framework#31343 to add support for limiting the number and size of file parts.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions