Skip to content

Add more gap between the orders of CloudFoundryVcapEnvironmentPostProcessor and ConfigDataEnvironmentPostProcessor #38684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvmw opened this issue Dec 6, 2023 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@kvmw
Copy link
Contributor

kvmw commented Dec 6, 2023

CloudFoundryVcapEnvironmentPostProcessor's order is set to ConfigDataEnvironmentPostProcessor.ORDER - 1 to give it higher priority. These consecutive numbers ( N and N - 1 ) makes it impossible to register any other EnvironmentPostProcessor between them. Setting a bigger gap between two orders ( e.g. N and N - 5) fixes the issue.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 6, 2023
@wilkinsona
Copy link
Member

The earliest we could do this would be in a new minor release. Even that may be too soon as it could break backwards compatibility in a way that's hard to work around. I think we'll need to discuss our options here, perhaps we'll need an escape hatch that allows the old order to be reinstated.

@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Dec 7, 2023
@philwebb philwebb changed the title Add more gap between the orders of CloudFoundryVcapEnvironmentPostProcessor and ConfigDataEnvironmentPostProcessor Add more gap between the orders of CloudFoundryVcapEnvironmentPostProcessor and ConfigDataEnvironmentPostProcessor Dec 7, 2023
@philwebb
Copy link
Member

We talked about this and we're going to move the order of CloudFoundryVcapEnvironmentPostProcessor in 3.3. This seems like the least risky class to change.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Feb 21, 2024
@philwebb philwebb added this to the 3.3.x milestone Feb 21, 2024
@mhalbritter mhalbritter self-assigned this Mar 26, 2024
@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.0-RC1 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants