Skip to content

Auto configure MessageConverter for JMS classes #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdeinum opened this issue Oct 23, 2015 · 1 comment
Closed

Auto configure MessageConverter for JMS classes #4282

mdeinum opened this issue Oct 23, 2015 · 1 comment
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
1.4.0.M2

Comments

@mdeinum
Copy link
Contributor

mdeinum commented Oct 23, 2015

Currently when a DestinationResolver is found in the context it is automatically registered on the JmsTemplate and DefaultJmsListenerContainerFactory.

It would be nice if this could also be the case for a MessageConverter.
@mdeinum mdeinum changed the title Auto configure MessageConverter for JmsTemplate Auto configure MessageConverter for JMS classes Oct 23, 2015
mdeinum pushed a commit to mdeinum/spring-boot that referenced this issue Oct 23, 2015
Autoconfigure MessageConverter for JMS classes
157a0d2 
 This commit introduces automatic configuration of the `messageConverter` property for both the `JmsTemplate` and `DefaultJmsListenerContainerFactory`.

 When a `MessageConverter` is configured it will be used to configure both classes.

 Fixes: spring-projectsgh-4282
@mdeinum mdeinum mentioned this issue Oct 23, 2015
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2015
@snicoll
Copy link
Member

snicoll commented Dec 21, 2015

Closing in favour of the pull request.

@snicoll snicoll closed this as completed Dec 21, 2015
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged label Dec 21, 2015
@snicoll snicoll reopened this Feb 29, 2016
@snicoll snicoll added the type: enhancement A general enhancement label Feb 29, 2016
@snicoll snicoll added this to the 1.4.0.M2 milestone Feb 29, 2016
@snicoll snicoll self-assigned this Feb 29, 2016
@philwebb philwebb modified the milestone: 1.4.0.M2 Feb 29, 2016
henrikerola pushed a commit to henrikerola/spring-boot that referenced this issue Mar 3, 2016
@snicoll @henrikerola
Auto-configure JMS MessageConverter
fee2c0f 
If a `MessageConverter` bean is available, we now associate it to the
created `JmsTemplate` and `JmsListenerContainerFactory`. That way,
registering a custom `MessageConverter` is all that's needed.

The JMS auto-configuration is now using the new `ObjectProvider` that
offers a nicer API to detect if a primary candidate is available for
optional collaborators.

Closes spring-projectsgh-4282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.4.0.M2
Development

No branches or pull requests
4 participants
@snicoll @philwebb @mdeinum @spring-projects-issues