Various spring.datasource properties are mistakenly marked as ignored

[kzander91]

Commit 8536520 in #43988 added a variety of properties to a list of ignored properties due them being "unbindable", however several of them are bindable.

I have been using the following properties just fine for years, however when building against 3.5.0 snapshots, my IDE is now giving me warnings about those properties being unknown. Note that binding them at runtime still works though:

• spring.datasource.hikari.data-source-properties, example: spring.datasource.hikari.data-source-properties.oracle.jdbc.ReadTimeout=60000.
• spring.datasource.oracleucp.connection-properties, example: spring.datasource.oracleucp.connection-properties.oracle.jdbc.ReadTimeout=60000.

I'm not using spring.datasource.hikari.health-check-properties, but that seems to be affected as well.

I propose to review the list of ignored properties and reinstate those that are indeed bindable.

[mhalbritter]

Hey,

thanks for giving the milestones / release candidates / snapshots a try!

I mistakenly thought that Properties aren't bindable. Those properties are indeed bindable:

• spring.datasource.hikari.data-source-properties
• spring.datasource.hikari.health-check-properties
• spring.datasource.oracleucp.connection-factory-properties
• spring.datasource.oracleucp.connection-properties
• spring.datasource.oracleucp.pdb-roles
• spring.datasource.tomcat.db-properties

[kzander91]

Thanks @mhalbritter, warnings are gone with the latest snapshots 👍

[mhalbritter]

Thanks for confirming!

[JanMosigItemis]

Hello everyone,

just wanted to let you know: This change may fix a "bug" that production code already depends on, i. e. one of our tests failed, because the default value for spring.datasource.hikari.maximumPoolSize was expected to be "-1", but now is 10 since we migrated from SpringBoot starter 3.4.6 to 3.5.0.

Not 100% sure though if this PR is actually responsible for this, because the test exists since 2023-09 and always used to be green until now.

[nosan]

Hi @JanMosigItemis,
This issue is not related to changing maximumPoolSize from -1 to 10.
See

• brettwooldridge/HikariCP@8dde168
• brettwooldridge/HikariCP@bbd698e

[JanMosigItemis]

Yeah that is what's confusing me. We only bumped dependencies and suddenly the test fails. Maybe it is a combination of multiple things.

[nosan]

Spring Boot 3.4.x depends on Hikari 5.1.0.

Spring Boot 3.5.0 depends on Hikari 6.3.0 (which includes changes to maximumPoolSize)

[JanMosigItemis]

Thanks for pointing that out. Now things make sense.