Skip to content

PropertiesConfigurationFactory.setProperties(Properties) is only used in tests #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue May 12, 2016 · 3 comments
Closed

PropertiesConfigurationFactory.setProperties(Properties) is only used in tests #5930

wilkinsona opened this issue May 12, 2016 · 3 comments
Milestone
1.4.0.M3

Comments

@wilkinsona
Copy link
Member

Should we deprecate/remove it?
@philwebb
Copy link
Member

I'm guessing since we removed @ConfigurationProperties.locations we don't need it. I vote yes.

@philwebb philwebb added this to the 1.4.0.M3 milestone May 12, 2016
@wilkinsona
Copy link
Member Author

FWIW, we only deprecated locations so I don't think that's what was using it.

@philwebb
Copy link
Member

Hmm, I wonder why it was added. I'm still in favor of deprecating it if we're not using it ourselves.

philwebb added a commit that referenced this issue May 14, 2016
@philwebb
Deprecate setProperties on ConfigurationFactory
434ab5d 
Deprecate `PropertiesConfigurationFactory.setProperties()` since it was
only being used in tests.

Fixes gh-5930
philwebb added a commit that referenced this issue May 14, 2016
@philwebb
Deprecate setProperties on ConfigurationFactory
66b69f4 
Deprecate `PropertiesConfigurationFactory.setProperties()` since it was
only being used in tests.

Fixes gh-5930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0.M3
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona