Skip to content

Introduce "server.servlet" prefix for servlet specific properties #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bclozel opened this issue Jan 23, 2017 · 3 comments
Closed

Introduce "server.servlet" prefix for servlet specific properties #8066

bclozel opened this issue Jan 23, 2017 · 3 comments
Assignees
Labels
theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Jan 23, 2017

This change would break the current arrangement with ServerProperties and nest all Servlet specific keys under a servlet prefix.

Current key New key
server.address
server.compression
server.connection-timeout
server.context-parameters.* server.servet.context-parameters.*
server.context-path server.servlet.context-path
server.display-name
server.max-http-header-size
server.max-http-post-size
server.error.[...] should we move this to an "mvc" namespace?
server.jetty.[...]
server.jsp-servlet.[...] server.servlet.jsp.[...]
server.port
server.session.tracking-mode warning: type javax.servlet.SessionTrackingMode
server.server-header
server.servlet-path server.servlet.path
server.use-forward-headers
server.session.[...]
server.ssl.[...]
server.tomcat.[...]
server.undertow.[...]

Servlet specific properties should not apply when an application is deployed on a reactive runtime (even if it's a servlet container); in that case, we could silently ignore those or fail hard at startup.

New runtimes will be introduced, such as RxNetty and Reactor Netty (both based on netty). Configuration keys should be added as well.

Relates to #3659 and #4818

@bclozel bclozel added priority: high theme: config-data Issues related to the configuration theme type: enhancement A general enhancement labels Jan 23, 2017
@bclozel bclozel added this to the 2.0.0.M1 milestone Jan 23, 2017
@bclozel bclozel self-assigned this Jan 23, 2017
@snicoll
Copy link
Member

snicoll commented Jan 23, 2017

jsp-servlet always bugged me, can we go with spring.servlet.jsp please?

@bclozel
Copy link
Member Author

bclozel commented Jan 23, 2017

In that case, it would look like:

  • server.servlet.jsp.class-name
  • server.servlet.jsp.init-parameters.*
  • server.servlet.jsp.registered

bclozel added a commit to bclozel/spring-boot that referenced this issue Jan 25, 2017
This commit refactor the `ServerProperties` property keys and introduces
a separate "server.servlet" namespace to isolate servlet-specific
properties from the rest.

This change also introduces `ServerPropertiesContainerCustomizer`, which
takes the servlet container customization code out of the
`ServerProperties`, allowing it to focus on properties management.

Fixes spring-projects#8066
bclozel added a commit to bclozel/spring-boot that referenced this issue Jan 25, 2017
This commit refactor the `ServerProperties` property keys and introduces
a separate "server.servlet" namespace to isolate servlet-specific
properties from the rest.

This change also introduces `ServerPropertiesContainerCustomizer`, which
takes the servlet container customization code out of the
`ServerProperties`, allowing it to focus on properties management.

Fixes spring-projects#8066
@snicoll
Copy link
Member

snicoll commented Feb 2, 2017

See also #3016

@bclozel bclozel closed this as completed in 12d883f Feb 7, 2017
bclozel added a commit that referenced this issue Feb 8, 2017
This commit creates a separate
`ServerPropertiesServletContainerCustomizer` that holds the servlet
container customization code, separating that concern from the server
configuration keys.

See gh-8066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants