-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Introduce "server.servlet" prefix for servlet specific properties #8066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
theme: config-data
Issues related to the configuration theme
type: enhancement
A general enhancement
Milestone
Comments
|
In that case, it would look like:
|
bclozel
added a commit
to bclozel/spring-boot
that referenced
this issue
Jan 25, 2017
This commit refactor the `ServerProperties` property keys and introduces a separate "server.servlet" namespace to isolate servlet-specific properties from the rest. This change also introduces `ServerPropertiesContainerCustomizer`, which takes the servlet container customization code out of the `ServerProperties`, allowing it to focus on properties management. Fixes spring-projects#8066
bclozel
added a commit
to bclozel/spring-boot
that referenced
this issue
Jan 25, 2017
This commit refactor the `ServerProperties` property keys and introduces a separate "server.servlet" namespace to isolate servlet-specific properties from the rest. This change also introduces `ServerPropertiesContainerCustomizer`, which takes the servlet container customization code out of the `ServerProperties`, allowing it to focus on properties management. Fixes spring-projects#8066
See also #3016 |
bclozel
added a commit
that referenced
this issue
Feb 8, 2017
This commit creates a separate `ServerPropertiesServletContainerCustomizer` that holds the servlet container customization code, separating that concern from the server configuration keys. See gh-8066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme: config-data
Issues related to the configuration theme
type: enhancement
A general enhancement
This change would break the current arrangement with
ServerProperties
and nest all Servlet specific keys under aservlet
prefix.javax.servlet.SessionTrackingMode
Servlet specific properties should not apply when an application is deployed on a reactive runtime (even if it's a servlet container); in that case, we could silently ignore those or fail hard at startup.
New runtimes will be introduced, such as RxNetty and Reactor Netty (both based on netty). Configuration keys should be added as well.
Relates to #3659 and #4818
The text was updated successfully, but these errors were encountered: